chore: update playwright in ci to run only on aria changes #4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/chore-run-tests-only-if-aria-changed |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Playwright testing infrastructure to separate different types of accessibility tests and only run aria-related tests when aria changes are detected. The key changes include splitting consolidated test files into separate test suites by test type (visual snapshots, aria snapshots, axe-core, and a11y-checker) and updating CI workflows to run tests conditionally based on detected changes.
- Separate test files by test type for better organization and selective execution
- Update CI workflows to run aria-related tests only when aria changes are detected
- Add new Playwright configuration files for different test types
- Update package.json scripts across all showcases to support the new test structure
Reviewed Changes
Copilot reviewed 146 out of 151 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| showcases/*/package.json | Add separate npm scripts for each test type (aria-snapshots, visual-snapshots, axe-core, a11y-checker) |
| showcases/playwright.*.ts | New Playwright configuration files for different test types with specific test matching patterns |
| showcases/e2e//.spec.ts | Split existing combined test files into separate files by test type |
| .github/workflows/*.yml | Update CI workflows to run tests conditionally and use new test scripts |
| scripts/github/snapshot-changes/*.ts | Add utility scripts to detect snapshot changes for conditional test execution |
…if-aria-changed # Conflicts: # .github/workflows/02-e2e-showcases.yml # __snapshots__/custom-select/showcase/webkit/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png # package-lock.json # showcases/e2e/switch/switch-axe-core.spec.ts # showcases/e2e/tabs/tabs-axe-core.spec.ts # showcases/react-showcase/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Further comments